Skip to content
  • Michele Mancioppi's avatar
    01b39e77
    Implement aws.ecs.* resource attributes (#2626) · 01b39e77
    Michele Mancioppi authored
    
    
    * Implemented aws.ecs.* resource attributes in go.opentelemetry.io/detectors/aws/ecs
    
    * Update detectors/aws/ecs/ecs_test.go
    
    Co-authored-by: default avatarChester Cheung <[email protected]>
    
    * Update detectors/aws/ecs/ecs_test.go
    
    Co-authored-by: default avatarChester Cheung <[email protected]>
    
    * fix: lower-case the value of aws.ecs.launchtype
    
    * Add aws.logs.* support, remove spurious /aws prefix from log group
    
    * Add tests for V4 on Fargate launch type
    
    * Rebase
    
    * Fix integration tests, fix behavior on Windows
    
    After a surreal session of debugging, it turns out that httptest.NewServer fails on Windows by failing to bind the server socket unless the GoLang package name contains "test". To deal with that, I split the tests between "integration tests" needing a HTTP server into "ecs/test", and the other in "ecs".
    
    In order to work around the need of being resilient to the lack of /proc/self/cgroup (which happens in our tests but, above all, when running containers on Windows), the ECVS detector is now more lenient to not finding the container id.
    
    Co-authored-by: default avatarChester Cheung <[email protected]>
    01b39e77
    Implement aws.ecs.* resource attributes (#2626)
    Michele Mancioppi authored
    
    
    * Implemented aws.ecs.* resource attributes in go.opentelemetry.io/detectors/aws/ecs
    
    * Update detectors/aws/ecs/ecs_test.go
    
    Co-authored-by: default avatarChester Cheung <[email protected]>
    
    * Update detectors/aws/ecs/ecs_test.go
    
    Co-authored-by: default avatarChester Cheung <[email protected]>
    
    * fix: lower-case the value of aws.ecs.launchtype
    
    * Add aws.logs.* support, remove spurious /aws prefix from log group
    
    * Add tests for V4 on Fargate launch type
    
    * Rebase
    
    * Fix integration tests, fix behavior on Windows
    
    After a surreal session of debugging, it turns out that httptest.NewServer fails on Windows by failing to bind the server socket unless the GoLang package name contains "test". To deal with that, I split the tests between "integration tests" needing a HTTP server into "ecs/test", and the other in "ecs".
    
    In order to work around the need of being resilient to the lack of /proc/self/cgroup (which happens in our tests but, above all, when running containers on Windows), the ECVS detector is now more lenient to not finding the container id.
    
    Co-authored-by: default avatarChester Cheung <[email protected]>
Loading